Rectify the default attention mode "node" of the nn.HypergraphConv layer
#8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty1s
approved these changes
Jan 25, 2024
rusty1s
changed the title
nn.HypergraphConv layer.nn.HypergraphConv layer
|
You're most welcome. I appreciate your prompt response in addressing this issue, and it is also my aspiration to enhance the excellence of pyg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, esteemed individuals.
While acquainting myself with the utilization of the nn.HypergraphConv layer through the application of mock inputs, I have encountered an issue with the default attention mode, namely "node," which disrupts the functionality of the forward function.
Upon examining the source code, I have identified a potential problem with the num_nodes parameter within the softmax function at line 177. From my perspective, when attempting to compute attention scores for nodes within a hyperedge, the number of hyperedges should be considered as num_nodes.
Therefore, I have modified the value of num_nodes to correspond to the pre-calculated quantity of num_edges. As a result, the issue has been resolved, and the functionality has been restored harmoniously.
Warmest regards.