-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphgym
: A correction in documentation and added information on how to install requirements
#8842
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example_node.yaml
is located in pyg
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About pip install torch-geometric[graphgym]
, I wonder if running this command could replace the installed version of the package. I suppose one should have the same version of the package installed and the (git-)cloned to use graphgym
. But if this is not the case, users could lose their installed version of pyg
.
I had suggested separating the requirements from toml and installing them, for this reason. By installing only the requirements, users would not lose their installed version of pyg
.
IMO, it will not override the existing version of the package. This is definitely the recommended way to install the missing dependencies. I personally would like to avoid adding a script that parses the toml and creates a requirement file from it. |
graphgym
,configs/example_node.yaml
should beconfigs/pyg/example_node.yaml
, based on the current location of that file in the repository.graphgym
. So I added agraphgym/configure.py
file which extractsgraphgym
's requirements from thepyproject.toml
. Accordingly, following line is added in the documentation:I hope this helps.