Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect boolean tensors when creating dummies in to_homogeneous() #8858

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Respect boolean tensors when creating dummies in to_homogeneous() #8858

merged 2 commits into from
Feb 3, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Feb 3, 2024 •
edited

Fixes #8856

@github-actions github-actions bot added the data label Feb 3, 2024
@rusty1s rusty1s self-assigned this Feb 3, 2024
@rusty1s rusty1s mentioned this pull request Feb 3, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c21944a) 89.40% compared to head (16965a3) 89.40%.

Files Patch % Lines
torch_geometric/data/hetero_data.py 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8858      +/-   ##
==========================================
- Coverage   89.40%   89.40%   -0.01%     
==========================================
  Files         479      479              
  Lines       31180    31184       +4     
==========================================
+ Hits        27877    27879       +2     
- Misses       3303     3305       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 5004ac0 into master Feb 3, 2024
16 of 17 checks passed
@rusty1s rusty1s deleted the respect_bool_in_to_homo branch February 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mananshah99 mananshah99 Awaiting requested review from mananshah99 mananshah99 is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] HeteroData.to_homogeneous() doesn't handle the train/val/test mask correctly
1 participant
@rusty1s