Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use segment in case torch.use_deterministic_algorithms is set #9009

Merged
merged 27 commits into from
Mar 4, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 3, 2024

No description provided.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.24%. Comparing base (fefa636) to head (562738b).

Files Patch % Lines
torch_geometric/nn/aggr/base.py 88.88% 1 Missing ⚠️
torch_geometric/utils/_segment.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9009      +/-   ##
==========================================
- Coverage   89.86%   89.24%   -0.62%     
==========================================
  Files         468      468              
  Lines       30043    30043              
==========================================
- Hits        26998    26812     -186     
- Misses       3045     3231     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit d491f43 into master Mar 4, 2024
15 checks passed
@rusty1s rusty1s deleted the use_deterministic branch March 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant