Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filtering of node/edge types in trim_to_layer #9021

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 5, 2024

This is not safe in most cases, since a filtering of an empty edge type may lead to the unexpected drop of node features.

Fixes #9015

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (0d30e89) to head (94726c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9021      +/-   ##
==========================================
- Coverage   89.24%   89.24%   -0.01%     
==========================================
  Files         468      468              
  Lines       30044    30034      -10     
==========================================
- Hits        26813    26803      -10     
  Misses       3231     3231              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit af0f5f4 into master Mar 5, 2024
13 checks passed
@rusty1s rusty1s deleted the remove_filter_trim branch March 5, 2024 14:01
project-delphi added a commit to project-delphi/pytorch_geometric that referenced this pull request Mar 6, 2024
Remove filtering of node/edge types in `trim_to_layer` (pyg-team#9021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty feature generated when a graph is empty and trim_to_layer is enabled
1 participant