Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve memory option in ApproxKNN #9046

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Reserve memory option in ApproxKNN #9046

merged 4 commits into from
Mar 11, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 11, 2024

No description provided.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.25%. Comparing base (ec4cde3) to head (1b9f032).

Files Patch % Lines
torch_geometric/nn/pool/knn.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9046      +/-   ##
==========================================
- Coverage   89.26%   89.25%   -0.02%     
==========================================
  Files         468      468              
  Lines       30041    30049       +8     
==========================================
+ Hits        26815    26819       +4     
- Misses       3226     3230       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit e697d26 into master Mar 11, 2024
14 of 15 checks passed
@rusty1s rusty1s deleted the reserve_memory_in_knn branch March 11, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant