Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #9242

Merged
merged 50 commits into from
Apr 27, 2024
Merged

Cleanup #9242

merged 50 commits into from
Apr 27, 2024

Conversation

puririshi98
Copy link
Contributor

cleaning up to address review for #9167

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 16.12903% with 234 lines in your changes are missing coverage. Please review.

Project coverage is 81.91%. Comparing base (824e33b) to head (75082cb).
Report is 454 commits behind head on gnn-llm-model-integration.

❗ Current head 75082cb differs from pull request most recent head f2ab979. Consider uploading reports for the commit f2ab979 to get more accurate results

Files Patch % Lines
torch_geometric/nn/models/g_retriever.py 11.30% 102 Missing ⚠️
torch_geometric/nn/text/llm.py 16.52% 101 Missing ⚠️
...eometric/nn/text/sentence_transformer_embedding.py 20.51% 31 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           gnn-llm-model-integration    #9242      +/-   ##
=============================================================
- Coverage                      87.12%   81.91%   -5.22%     
=============================================================
  Files                            459      474      +15     
  Lines                          29851    30468     +617     
=============================================================
- Hits                           26008    24958    -1050     
- Misses                          3843     5510    +1667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

puririshi98 and others added 27 commits April 26, 2024 11:53
@puririshi98 puririshi98 merged commit 2463a43 into gnn-llm-model-integration Apr 27, 2024
12 of 15 checks passed
@puririshi98 puririshi98 deleted the cleanup branch April 27, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant