Fix typo in cga.Round.radius that made it always 1 (#372)

`/` should have been `/=`.
pygae · Oct 22, 2020 · 1c3c200 · 1c3c200
1 parent 67ea8ae
commit 1c3c200
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/clifford/cga.py b/clifford/cga.py
@@ -302,7 +302,7 @@ def radius(self):
         radius of the round (a float)
         '''
         dual_sphere = self.dual
-        dual_sphere / (-dual_sphere | self.cga.einf)
+        dual_sphere /= (-dual_sphere | self.cga.einf)
         return math.sqrt(abs(dual_sphere * dual_sphere))
 
     @property

diff --git a/clifford/test/test_cga.py b/clifford/test/test_cga.py
@@ -81,7 +81,6 @@ def test_from_points_construction(cga, method):
     assert method(cga, e1, e2, e3).mv == method(cga, e1, e2, cga.up(e3)).mv
 
 
-@pytest.mark.xfail(raises=AssertionError, reason='gh-184')
 def test_round_from_center_radius_init(cga):
     blades = cga.layout.blades
     e1 = blades['e1']
@@ -92,7 +91,6 @@ def test_round_from_center_radius_init(cga):
     npt.assert_almost_equal(c.radius, 5)
 
 
-@pytest.mark.xfail(raises=AssertionError, reason='gh-184')
 def test_round_from_center_radius_method(cga):
     blades = cga.layout.blades
     e1 = blades['e1']