Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Pdiffs, sPds, and Pdop_identity #194

Merged
merged 1 commit into from Dec 19, 2019
Merged

Deprecate Pdiffs, sPds, and Pdop_identity #194

merged 1 commit into from Dec 19, 2019

Conversation

eric-wieser
Copy link
Member

These attributes all have shorter spellings, and now that __eq__ and __ne__ work, there's little need to cache them.

@eric-wieser eric-wieser added the component: differential operators Dop, Pdop, Sdop, grad, rgrad, etc label Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019 •
edited

Codecov Report

Merging #194 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   70.51%   70.53%   +0.02%     
==========================================
  Files           9        9              
  Lines        4609     4613       +4     
==========================================
+ Hits         3250     3254       +4     
  Misses       1359     1359
Impacted Files Coverage Δ
galgebra/mv.py 72.36% <100%> (ø) ⬆️
galgebra/ga.py 73.9% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a16a0...a15abea. Read the comment docs.

@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label Dec 19, 2019
@eric-wieser
Deprecate Pdiffs, sPds, and Pdop_identity
a15abea 
These attributes all have shorter spellings, and now that `__eq__` and `__ne__` work, there's little need to cache them.
utensil
utensil approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the shorter spellings in the Changelog in later PRs.

@utensil utensil merged commit 0b8c38a into pygae:master Dec 19, 2019
@eric-wieser eric-wieser added the state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done. label Dec 19, 2019
@eric-wieser eric-wieser mentioned this pull request Dec 19, 2019
Open
@utensil utensil added this to the 0.4.5 milestone Dec 28, 2019
@eric-wieser eric-wieser deleted the remove-Pdiffs branch April 20, 2020 13:04
@eric-wieser eric-wieser added the Deprecation Precursor to removal of features label Apr 30, 2020
@eric-wieser eric-wieser removed the state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done. label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utensil utensil utensil approved these changes

Assignees
No one assigned
Labels
component: differential operators Dop, Pdop, Sdop, grad, rgrad, etc Deprecation Precursor to removal of features ✓ soft CI failure PRs which fail quality but not test CIs
Projects
None yet
Milestone
0.4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @utensil