Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect right and left contraction on scalars #431

Merged
merged 2 commits into from Jun 2, 2020

Conversation

eric-wieser
Copy link
Member

xref #54

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #431 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
+ Coverage   78.20%   78.27%   +0.07%     
==========================================
  Files          16       16              
  Lines        4207     4207              
==========================================
+ Hits         3290     3293       +3     
+ Misses        917      914       -3     
Impacted Files Coverage Δ
galgebra/mv.py 75.45% <100.00%> (+0.18%) ⬆️
galgebra/ga.py 82.52% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9f090...274591b. Read the comment docs.

@eric-wieser eric-wieser added the bug label Jun 2, 2020
@eric-wieser eric-wieser added this to the 0.5.0 milestone Jun 2, 2020
@eric-wieser eric-wieser requested a review from utensil June 2, 2020 14:58
@eric-wieser eric-wieser marked this pull request as ready for review June 2, 2020 14:58
@eric-wieser eric-wieser merged commit db33ed5 into pygae:master Jun 2, 2020
Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eric-wieser eric-wieser deleted the swap-flipped-contractions branch August 10, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants