-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mixer.Channel.set_source_location() #1844
Conversation
We could perhaps have an interactive test here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
New test works great!
I assumed from the title of this PR that this was a way to set the playback time of a channel. I.e. rewind or seek forward to a time. I'm quite excited to see it's actually about setting the direction of a sound effect. That could be a super cool effect! However I'm wondering if we can get a more clear name than |
I believe this is usually called positional audio. Looking elsewhere OpenAL uses a concept of audio sources for its positional audio implementation - perhaps we could go with something like |
This function should support float input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Example:
You should hear the sound running around you.