Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean video.pyx (Move declarations to pxd file) #1939

Merged
merged 4 commits into from
May 17, 2023
Merged

Clean video.pyx (Move declarations to pxd file) #1939

merged 4 commits into from
May 17, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Feb 25, 2023

No description provided.

@yunline yunline requested a review from a team as a code owner February 25, 2023 02:34
@Mega-JC Mega-JC added the _sdl2 pygame._sdl2 label Feb 26, 2023
MyreMylar
MyreMylar approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

zoldalma999
zoldalma999 approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yunline
Copy link
Contributor Author

yunline commented May 17, 2023

Sorry I messed it up. Fortunately it鈥榮 ok now.

@yunline yunline added this to the 2.3 milestone May 17, 2023
@yunline yunline added the Code quality/robustness Code quality and resilience to changes label May 17, 2023
@yunline yunline merged commit 88c3685 into pygame-community:main May 17, 2023
29 checks passed
@yunline yunline deleted the cython-clean branch May 17, 2023 01:05
Mega-JC pushed a commit to Mega-JC/pygame-ce that referenced this pull request May 21, 2023
@yunline @Mega-JC
Move declarations to pxd (pygame-community#1939)
147977f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yunline @MyreMylar @zoldalma999 @Mega-JC