Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug method #2

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Debug method #2

merged 4 commits into from
Feb 17, 2023

Conversation

oddbookworm
Copy link
Member

MyreMylar
MyreMylar reviewed Feb 12, 2023
View reviewed changes
buildconfig/stubs/pygame/_debug.pyi Outdated

def str_from_tuple(version_tuple: Union[Tuple[int, int, int], None]) -> str: ...
def attempt_import(module: str, function_name: str, output_str: str="") -> ImportResult: ...
def print_debug_info(filename: Optional[str] = None) -> None: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you need a new line on the end of this file.

MyreMylar
MyreMylar approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output still looks good over here:

Platform:		Windows-10-10.0.22621-SP0
System:			Windows
System Version:		10.0.22621
Processor:		AMD64 Family 23 Model 113 Stepping 0, AuthenticAMD
Architecture:		Bits: 64bit	Linkage: WindowsPE

Python:			CPython
pygame version:		2.1.4.dev1
python version:		3.11.1

SDL versions:		Linked: 2.0.22	Compiled: 2.0.22
SDL Mixer versions:	Linked: 2.6.2	Compiled: 2.6.2
SDL Font versions:	Linked: 2.20.1	Compiled: 2.20.1
SDL Image versions:	Linked: 2.0.5	Compiled: 2.0.5
Freetype versions:	Linked: 2.11.1	Compiled: 2.11.1

@MyreMylar MyreMylar closed this Feb 13, 2023
@MyreMylar
Copy link
Member

Huh, I can't re-open this one to trigger the CI for some reason.

@MyreMylar
Copy link
Member

@oddbookworm maybe you can re-open it?

@oddbookworm oddbookworm reopened this Feb 13, 2023
Matiiss
Matiiss requested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be functional, I get all the debug info, so that's great. 👍

Mainly would be great if you could add docstrings as seemingly most functions in src_py have them, so for consistency, they should be added here too.

src_py/_debug.py Outdated Show resolved Hide resolved
src_py/_debug.py Outdated Show resolved Hide resolved
src_py/_debug.py Outdated Show resolved Hide resolved
src_py/_debug.py Show resolved Hide resolved
src_py/_debug.py Outdated Show resolved Hide resolved
@oddbookworm oddbookworm requested a review from a team as a code owner February 16, 2023 01:19
Matiiss
Matiiss requested changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a tiny formatting issue which apparently hasn't been picked up by the formatter, there are also docstrings to be added to those functions because existing modules have them.

buildconfig/stubs/pygame/_debug.pyi Outdated Show resolved Hide resolved
@oddbookworm oddbookworm reopened this Feb 16, 2023
Matiiss
Matiiss approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice feature 👍

@Matiiss Matiiss added this to the 2.1.4 milestone Feb 16, 2023
@Matiiss Matiiss added the New API This pull request may need extra debate as it adds a new class or function to pygame label Feb 16, 2023
MyreMylar
MyreMylar approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

current output:

Platform:		Windows-10-10.0.22621-SP0
System:			Windows
System Version:		10.0.22621
Processor:		AMD64 Family 23 Model 113 Stepping 0, AuthenticAMD
Architecture:		Bits: 64bit	Linkage: WindowsPE
Driver:			windows

Python:			CPython
pygame version:		2.1.4.dev1
python version:		3.11.1

SDL versions:		Linked: 2.0.22	Compiled: 2.0.22
SDL Mixer versions:	Linked: 2.6.2	Compiled: 2.6.2
SDL Font versions:	Linked: 2.20.1	Compiled: 2.20.1
SDL Image versions:	Linked: 2.0.5	Compiled: 2.0.5
Freetype versions:	Linked: 2.11.1	Compiled: 2.11.1

@MyreMylar MyreMylar merged commit 10a126e into pygame-community:main Feb 17, 2023
@oddbookworm oddbookworm deleted the debug_method branch February 23, 2023 03:48
Carbon32 added a commit to Carbon32/pygame-ce that referenced this pull request Sep 12, 2023
@Carbon32 @dr0id
Update docs/readmes/README.es.rst
a0cf9cb 
Quick Fix pygame-community#2

Co-authored-by: dr0id <dr0id@bluewin.ch>
Matiiss pushed a commit that referenced this pull request Sep 21, 2023
@Carbon32 @dr0id
Spanish Translation (#2430)
e87dd4d 
* Added spanish translation to README

* A quick fix

* Fixed formatting

* Update docs/readmes/README.es.rst

Punctuation

Co-authored-by: dr0id <dr0id@bluewin.ch>

* Update docs/readmes/README.es.rst

Quick Fix #1

Co-authored-by: dr0id <dr0id@bluewin.ch>

* Update docs/readmes/README.es.rst

Quick Fix #2

Co-authored-by: dr0id <dr0id@bluewin.ch>

* Update docs/readmes/README.es.rst

Another quick fix

Co-authored-by: dr0id <dr0id@bluewin.ch>

* Some fixes & improvements

* Removed unused docs

* Removed more unused docs

* Added back a tiny detail

---------

Co-authored-by: dr0id <dr0id@bluewin.ch>
MyreMylar added a commit that referenced this pull request Nov 12, 2023
@MyreMylar @Starbuck5
Add SIMD versions of the greyscale transform (attempt #2) (#2432)
acdb21f 
* Add SIMD versions of greyscale transform

---------

Co-authored-by: Starbuck5 <46412508+Starbuck5@users.noreply.github.com>
ankith26 added a commit that referenced this pull request Nov 12, 2023
@ankith26
attempt #2 at libpng windows
869cbd9
ankith26 added a commit that referenced this pull request Nov 12, 2023
@ankith26
attempt #2 at libpng windows
c0508ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@Matiiss Matiiss Matiiss approved these changes

Assignees
No one assigned
Labels
New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oddbookworm @MyreMylar @Matiiss