Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pygame.image.tostring and fromstring #2101

Merged
merged 4 commits into from
Apr 30, 2023

Conversation

SSS-Says-Snek
Copy link
Member

@SSS-Says-Snek SSS-Says-Snek commented Apr 7, 2023

Fixes #2085

Since to/fromstring's gonna be deprecated, I also replaced usage of them in tests to to/frombytes
Finally, like I mentioned on the discord, because to/frombytes and to/fromstring's docs were the exact same and made it hard to follow, I replaced it with a redirection to to/frombytes

@SSS-Says-Snek SSS-Says-Snek requested a review from a team as a code owner April 7, 2023 05:56
@Starbuck5
Copy link
Member

Thanks for working on this!

My only review notes is for the docs:

  • The functions with removed documentation should at least say something like "This is the same functionality as frombytes"
  • The reference to the new function should be a sphinx link to the new function. For example, ":func:`pygame.image.load()`" is a link to the function.

In case you haven't built the docs before, do python setup.py docs (with sphinx installed), and then access them with python -m docs

@SSS-Says-Snek
Copy link
Member Author

Alright, I'll fix it when I get back

@SSS-Says-Snek
Copy link
Member Author

Soo I won't be back for 6 more days💀

@novialriptide
Copy link
Member

🚗

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🎉

Left a minor nitpick-ey review, resolve at will

src_c/image.c Outdated Show resolved Hide resolved
@Starbuck5 Starbuck5 merged commit 8525bae into pygame-community:main Apr 30, 2023
29 checks passed
@Starbuck5 Starbuck5 added this to the 2.3 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate image.tostring, image.fromstring
4 participants