-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate pygame.image.tostring and fromstring #2101
Deprecate pygame.image.tostring and fromstring #2101
Conversation
Thanks for working on this! My only review notes is for the docs:
In case you haven't built the docs before, do |
Alright, I'll fix it when I get back |
Soo I won't be back for 6 more days💀 |
🚗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR! 🎉
Left a minor nitpick-ey review, resolve at will
Fixes #2085
Since
to/fromstring
's gonna be deprecated, I also replaced usage of them in tests toto/frombytes
Finally, like I mentioned on the discord, because to/frombytes and to/fromstring's docs were the exact same and made it hard to follow, I replaced it with a redirection to
to/frombytes