Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac wheels issue: sndfile disable lame mpeg #2118

Merged
merged 1 commit into from
May 1, 2023

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Apr 16, 2023

Edit Starbuck5 with more context: Issue where older macs can't do anything with audio because of a failed dlload of libmp3lame, a library we don't need. See https://www.reddit.com/r/pygame/comments/12k24f0/the_example_alienspy_wont_launch_no_matter_what/

@ankith26 ankith26 requested a review from a team as a code owner April 16, 2023 16:12
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, works!

@Starbuck5 Starbuck5 added this to the 2.3 milestone Apr 18, 2023
@Starbuck5
Copy link
Member

Confirmed with reporter on reddit that this fixes the problem.

@oddbookworm
Copy link
Member

I'll review at some point today

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the following config:

>>> pygame.print_debug_info()
Platform:		macOS-11.7.4-x86_64-i386-64bit
System:			Darwin
System Version:		Darwin Kernel Version 20.6.0: Fri Dec 16 00:35:00 PST 2022; root:xnu-7195.141.49~1/RELEASE_X86_64
Processor:		i386
Architecture:		Bits: 64bit	Linkage: 
Driver:			cocoa

Python:			CPython
pygame version:		2.3.0.dev1
python version:		3.11.2

SDL versions:		Linked: 2.26.4	Compiled: 2.26.4
SDL Mixer versions:	Linked: 2.6.3	Compiled: 2.6.3
SDL Font versions:	Linked: 2.20.2	Compiled: 2.20.2
SDL Image versions:	Linked: 2.0.5	Compiled: 2.0.5
Freetype versions:	Linked: 2.13.0	Compiled: 2.13.0

python -m pygame.examples.aliens worked perfectly

@oddbookworm oddbookworm merged commit 94c7412 into main May 1, 2023
27 checks passed
@MyreMylar MyreMylar deleted the ankith26-no-lame-mpeg branch May 29, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants