Fixes for tracker music support, add test #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
changed the title
Starbuck5
added
macOS
Windows
mixer.music
ankith26
reviewed
May 12, 2023
Just to be clear, I removed mp3 tests after adding them also in this PR. In the overall diff of this PR, no mp3 tests were removed. It's not that this PR removes mp3 tests. I opened an issue about the mp3 loading failing (#2154), and cool-guy-dev confirmed this problem does not occur on real built pygame wheels. It seems to only be a problem when getting SDL_mixer from apt on the Ubuntu sdist runs. This PR is totally ready for review, just focusing on |
|
LGTM, all tests pass on my machine. |
novialriptide
approved these changes
May 14, 2023
MyreMylar
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #2146
Problem: pygame-ce 2.2.1 has a regression where XM music doesn't work on Windows.
Regression caused by SDL_mixer, switching back down to 2.6.2 fixes it. Reported upstream: libsdl-org/SDL_mixer#518.
Solution: go back to using SDL_mixer 2.6.2 (on all platforms, for consistency), and add a unit test to ensure support on all platforms.
Problem 2: apparently xm music wasn't working on Mac? -> fixed by adjusting the build flags to disable shared libmodplug like all the other audio codec libraries.
Problem 3: manylinux build was doing something with docker that fails on PR branches unless they are direct branches of pygame-ce, so had to move my stuff to this new branch.