Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Color.from_<color_space> classmethods #2177

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Added Color.from_<color_space> classmethods #2177

merged 1 commit into from
Jul 11, 2023

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented May 18, 2023

Fixes #2121

@Matiiss Matiiss requested a review from a team as a code owner May 18, 2023 17:10
yunline
yunline reviewed May 19, 2023
View reviewed changes
src_c/color.c Show resolved Hide resolved
dr0id
dr0id approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when you undef the macro as suggested by @yunline

yunline
yunline approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoldalma999 zoldalma999 added New API This pull request may need extra debate as it adds a new class or function to pygame color pygame.color labels May 20, 2023
@Matiiss Matiiss changed the title Added Color.from_color_space classmethods Added Color.from_color_space classmethods May 29, 2023
Starbuck5
Starbuck5 reviewed Jul 1, 2023
View reviewed changes
docs/reST/ref/color.rst Outdated Show resolved Hide resolved
@Starbuck5
Copy link
Member

@Matiiss the commit history is a bit messy at this point, please squash at your discretion and then merge. :)

@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jul 11, 2023
@Matiiss
Added Color.from_color_space classmethods
5558081 
Fixed type and added versionadded to docs

More type stuff

formatting...

overlord

cls 🤦

This whitespace....

... so done

undef macro

updated versionadded
@Matiiss Matiiss force-pushed the matiiss-add-from_color_space branch from 1d42e98 to 5558081 Compare July 11, 2023 09:02
@Matiiss Matiiss merged commit 48b7206 into pygame-community:main Jul 11, 2023
29 checks passed
@ankith26 ankith26 changed the title Added Color.from_color_space classmethods Added Color.from_<color_space> classmethods Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id approved these changes

@yunline yunline yunline approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
color pygame.color New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

Creating pygame.Color object from HSLA.
5 participants
@Matiiss @Starbuck5 @dr0id @yunline @zoldalma999