Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor documentation updates #2183

Merged
merged 2 commits into from
May 22, 2023
Merged

Minor documentation updates #2183

merged 2 commits into from
May 22, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented May 20, 2023 •
edited

  • A warning about an SDL version released in 2006 is not relevant
  • We don't pin Sphinx anywhere else, so might as well just say pip install sphinx
  • SDLError -> pygame.error

@Starbuck5 Starbuck5 requested a review from a team as a code owner May 20, 2023 06:54
@Starbuck5 Starbuck5 added the docs label May 20, 2023
@Starbuck5 Starbuck5 requested a review from Matiiss May 20, 2023 06:59
Matiiss
Matiiss requested changes May 20, 2023
View reviewed changes
docs/reST/ref/music.rst Outdated Show resolved Hide resolved
docs/reST/ref/music.rst Outdated Show resolved Hide resolved
Matiiss
Matiiss approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yunline
yunline approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

novialriptide
novialriptide approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@novialriptide novialriptide left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. I didn't know docs/README.md existed tbh... lol 💀

docs/README.md Outdated Show resolved Hide resolved
Matiiss
Matiiss reviewed May 22, 2023
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
MyreMylar
MyreMylar approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 8994101 into pygame-community:main May 22, 2023
1 check passed
@MyreMylar MyreMylar added this to the 2.3 milestone May 22, 2023
@Starbuck5 Starbuck5 deleted the minor-docs branch May 23, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matiiss Matiiss Matiiss approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

@yunline yunline yunline approved these changes

@novialriptide novialriptide novialriptide approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Starbuck5 @MyreMylar @yunline @novialriptide @Matiiss @zoldalma999