Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of pygame-ce-ification #2194

Merged
merged 3 commits into from
May 25, 2023

Conversation

Starbuck5
Copy link
Member

No description provided.

@Starbuck5 Starbuck5 requested a review from a team as a code owner May 23, 2023 06:06
@yunline
Copy link
Contributor

yunline commented May 23, 2023

LGTM
These may also need to be changed:

pygame-ce/setup.py

Lines 154 to 159 in 8994101

if not hasattr(sys, 'version_info') or sys.version_info < (3, 7):
compilation_help()
raise SystemExit("Pygame requires Python3 version 3.7 or above.")
if IS_PYPY and sys.pypy_version_info < (7,):
raise SystemExit("Pygame requires PyPy version 7.0.0 above, compatible with CPython >= 3.7")

@Starbuck5
Copy link
Member Author

@yunline You can just push that change to this branch if you'd like.

It's something you can do easily with Github desktop, when you check out a PR branch.

@Starbuck5 Starbuck5 added the docs label May 23, 2023
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/reST/conf.py Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pygame-ce be completely unaffiliated package to pygame, or rather an extension/fork/improved version of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 馃帀 馃嵃

@ankith26 ankith26 added this to the 2.3 milestone May 25, 2023
@ankith26 ankith26 merged commit f83837f into pygame-community:main May 25, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants