Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Py_TYPE(self)->tp_free(self) instead of PyObject_Free #2196

Merged
merged 2 commits into from
May 26, 2023
Merged

Use Py_TYPE(self)->tp_free(self) instead of PyObject_Free #2196

merged 2 commits into from
May 26, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented May 23, 2023

Issue: #2189

@yunline
Py_TYPE(self)->tp_free(self)
cd1b557 
instead of `PyObject_Free`
@yunline yunline added the Code quality/robustness Code quality and resilience to changes label May 23, 2023
@yunline yunline requested a review from a team as a code owner May 23, 2023 08:54
@Starbuck5
Copy link
Member

event.c also uses PyObject_Free in its error handling in the Event type init.

ankith26
ankith26 approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉 🍰

@Starbuck5 Starbuck5 merged commit 71bc456 into pygame-community:main May 26, 2023
29 checks passed
@Starbuck5 Starbuck5 added this to the 2.3 milestone May 26, 2023
@yunline yunline deleted the obj_free branch May 26, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yunline @Starbuck5 @ankith26