Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added persian transaltion for README.rst #2201

Merged
merged 3 commits into from
May 31, 2023

Conversation

yolowex
Copy link
Contributor

@yolowex yolowex commented May 27, 2023

I translated the README.rst to Persian (فارسی) and put it into docs/readmes directory.

@yolowex yolowex requested a review from a team as a code owner May 27, 2023 19:30
@Starbuck5
Copy link
Member

Running this through Google translate, the last line is translated to "For more information about the license of each dependency, use the links below."

But there aren't any links below. It should say licenses are in the docs/licenses folder, like the English version.

@Starbuck5
Copy link
Member

Also in Google Translate I see mentions of the "paygame" library, presumably you put a "sounded-out" version of pygame into persian text?

Is that better than leaving the word "pygame" in English in the middle of sentences?

@yolowex
Copy link
Contributor Author

yolowex commented May 28, 2023

I'll start investigating this issues as soon as I'm back home

@yolowex
Copy link
Contributor Author

yolowex commented May 28, 2023

Also in Google Translate I see mentions of the "paygame" library, presumably you put a "sounded-out" version of pygame into persian text?

Is that better than leaving the word "pygame" in English in the middle of sentences?

Now that I think about it yes, it's better not to translate the framework's name to persian.

@yolowex
Copy link
Contributor Author

yolowex commented May 28, 2023

@Starbuck5 I fixed the problems you mentioned

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Starbuck5 Starbuck5 added the docs label May 29, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar added this to the 2.3 milestone May 31, 2023
@MyreMylar MyreMylar merged commit 44bd250 into pygame-community:main May 31, 2023
1 check passed
@yolowex yolowex deleted the squashed branch May 31, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants