Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated scrap related code. #2204

Merged
merged 2 commits into from
May 29, 2023
Merged

updated scrap related code. #2204

merged 2 commits into from
May 29, 2023

Conversation

that1guy232
Copy link
Contributor

#2084 I think this is the last example that uses scrap?

@that1guy232 that1guy232 requested a review from a team as a code owner May 28, 2023 01:36
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Starbuck5 Starbuck5 added examples scrap pygame.scrap _sdl2 pygame._sdl2 and removed _sdl2 pygame._sdl2 labels May 29, 2023
@Starbuck5
Copy link
Member

If you'd like to do some additional improvements to this example, you could use the pygame-ce multiline text implementation (plus font.align for centering) instead of the bespoke multiline text in this example.

Also it could use a title (set_caption).

Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for contributing again 👍

@Matiiss Matiiss merged commit be7ab7c into pygame-community:main May 29, 2023
1 check passed
@zoldalma999 zoldalma999 added this to the 2.3 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples scrap pygame.scrap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants