Update sse2neon to latest version #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
approved these changes
Jun 1, 2023
Starbuck5
added
Code quality/robustness
oddbookworm
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
I didn't notice any problems in my limited testing. @Starbuck5 mentioned in discord that he plans on doing more extensive testing locally though, so I'm not going to merge this PR even though now it meets the approval requirement.
|
Tested locally turning off AVX2 compilation and running SSE2 on x86_64, which is untested on CI. Test suite passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of work on #2042 where our old vendored version of sse2neon was generating lots of compiler warnings/errors with the latest compilers.
This version is the latest version of the header (as of writing) from:
https://github.com/DLTcollab/sse2neon
Unfortunately the latest release is about 5 months old and the errors appear to have only been fixed recently - so I just took the latest copy of the header file.