Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix search page green background in dark theme #2226

Merged
merged 1 commit into from
Jun 4, 2023
Merged

fix search page green background in dark theme #2226

merged 1 commit into from
Jun 4, 2023

Conversation

Notenlish
Copy link
Contributor

fixes the weird bug that @yunline reported
image

Here's how it looks currently
image

here's the light theme version:
image

@Notenlish Notenlish requested a review from a team as a code owner June 2, 2023 15:46
@NOTMEE12
Copy link

NOTMEE12 commented Jun 2, 2023

maybe make that searchbar longer to the length of the text (Searching for multiple words...) or make it centered, cause it's looks a lil' weird.

@Notenlish
Copy link
Contributor Author

maybe make that searchbar longer to the length of the text (Searching for multiple words...) or make it centered, cause it's looks a lil' weird.

I don't think centering it would make sense
image

@NOTMEE12
Copy link

NOTMEE12 commented Jun 2, 2023

Now I saw that the text is not centered.

@yunline yunline added the docs label Jun 3, 2023
yunline
yunline approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starbuck5
Starbuck5 approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem.

@Starbuck5 Starbuck5 merged commit abd7aeb into pygame-community:main Jun 4, 2023
@Starbuck5 Starbuck5 added this to the 2.3 milestone Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunline yunline yunline approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Notenlish @NOTMEE12 @yunline @Starbuck5