Fix SysFont None issue #2271
Merged
Fix SysFont None issue #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm shocked nobody found this in the dev release that was out for a week with it, and it's only now shown up 10 days after release. Yeah maybe we'll do a quicker than usual 2.3.1 to get this fix out. |
Starbuck5
approved these changes
Jun 24, 2023
oddbookworm
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pygame CE 2.3.0, a bug was introduced in which an error is raised by Pygame when initialising a
SysFontobject withNoneas shown below.This PR fixes the problem, and adds a test for it. Apologies, the error was almost certainly introduced in my PR #2147. It might be worth pushing this fix out in a minor version.