Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore SDL 2.0.9 support #2272

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jun 24, 2023

This is important for people using Debian Buster, which is on SDL 2.0.9 (https://packages.debian.org/buster/libsdl2-2.0-0)
-- AKA Kyuchumimo's raspberry pi.
You can see on piwheels (https://www.piwheels.org/project/pygame-ce/) we lost support for 2.0.9 when pygame-ce 2.2.0 was released (FRects)

The oldest supported Ubuntu is 20.04, Focal, which is on SDL 2.0.10 (https://packages.ubuntu.com/focal/libsdl2-dev)

Therefore we should probably drop our stated support for SDL 2.0.8.

SDL 2.10.0 was released July 23rd 2019
SDL 2.0.9 was released October 30th 2018
SDL 2.0.8 was released March 1st 2018

@Starbuck5 Starbuck5 requested a review from a team as a code owner June 24, 2023 04:12
@Starbuck5 Starbuck5 added Code quality/robustness Code quality and resilience to changes Raspberry Pi Issues with the Raspberry Pi platform labels Jun 24, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable to me from a code skim - I'm not going back to 2018-era installs of SDL to test it though. Since it's not going to break anything for 90% of our users, as all this code is gated - Approved!

@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jun 29, 2023
@Starbuck5 Starbuck5 merged commit fd4f598 into pygame-community:main Jun 29, 2023
29 checks passed
@Starbuck5 Starbuck5 deleted the sdl-2.0.9-support branch June 29, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes Raspberry Pi Issues with the Raspberry Pi platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants