Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Rect.scale_by(|_ip) #2277

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Port Rect.scale_by(|_ip) #2277

merged 1 commit into from
Jul 7, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jun 29, 2023 •
edited

Credit goes to @dr0id for implementation and @jonotassia for keywords

This is mostly a straightforward code port, as is allowed under LGPL.

It did take me a while to get everything into the Rect/FRect system we've got, and to make sure the FRect tests demonstrated float-ness 馃槄

I'm not sure who wrote it, but this method has a huge test suite.

@Starbuck5 Starbuck5 added the rect pygame.rect label Jun 29, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner June 29, 2023 09:21
@Starbuck5 Starbuck5 marked this pull request as draft June 29, 2023 10:41
@Starbuck5 Starbuck5 marked this pull request as ready for review June 30, 2023 06:32
oddbookworm
oddbookworm approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ankith26
ankith26 reviewed Jul 1, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though you have correctly credited original authors in the PR comment, it would be nice to add co-authors in the git commit itself

PS: FYI I did some digging, and the tests seem to be written by the 2 people you have already credited

@Starbuck5
Copy link
Member Author

Starbuck5 commented Jul 2, 2023 •
edited

I've added the two original authors as co-authors on my commit.

ankith26
ankith26 reviewed Jul 5, 2023
View reviewed changes
docs/reST/ref/rect.rst Outdated Show resolved Hide resolved
ankith26
ankith26 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR as it's just a port of an upstream one. The minor nitpick I mentioned can also be left for later

@ankith26 ankith26 added the New API This pull request may need extra debate as it adds a new class or function to pygame label Jul 5, 2023
@Starbuck5 @jonotassia @dr0id
Port Rect.scale_by(|_ip)
ce2ca57 
Credit goes to @dr0id for implementation and @jonotassia for keywords

Co-Authored-By: Jono Tassia <jonotassia@gmail.com>
Co-Authored-By: dr0id <231898+dr0id@users.noreply.github.com>
@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jul 7, 2023
@Starbuck5 Starbuck5 merged commit c1da360 into pygame-community:main Jul 7, 2023
29 checks passed
@Starbuck5 Starbuck5 deleted the scaleby branch July 7, 2023 06:23
@zoldalma999 zoldalma999 mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
New API This pull request may need extra debate as it adds a new class or function to pygame rect pygame.rect
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Starbuck5 @ankith26 @oddbookworm