Add window hiddenimport #2287
Merged
Add window hiddenimport #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, but I can't test this on the os that encountered this issue, since it's not my pc and I can't have them build pygame from source. (unless it's included in a dev release?) |
|
Why can't you test this? This is not OS specific. This is pygame-ce version specific. Make a pyinstaller build of a program that uses Window. With this patch it works, without it it fails at runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2114, the Window class was moved to a hidden C module.
When distributing with PyInstaller, this C module is not picked up, so any program that uses Window fails at runtime only after building.
The solution to this is to add it as a hiddenimport to our pyinstaller hook.