Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new custom 'Sequence' ABC, fix issues #2292

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Jul 6, 2023

PR to tackle #2286 and related issues that arise from the usage of collections.abc.Sequence

@ankith26 ankith26 requested a review from a team as a code owner July 6, 2023 15:30
@ankith26 ankith26 added the type hints Type hint checking related tasks label Jul 6, 2023
@ankith26 ankith26 linked an issue Jul 6, 2023 that may be closed by this pull request
@ankith26
Copy link
Member Author

ankith26 commented Jul 14, 2023

Force pushed with only a merge-conflict fix.

PS: Ignore the force pushes after this, they were just experimenting with stuff, that I'll keep outta this PR, so they add nothing now

@ankith26 ankith26 force-pushed the ankith26-new-typing branch 3 times, most recently from f3e8c9e to 272cf0f Compare July 14, 2023 12:20
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddbookworm oddbookworm added this to the 2.3.1 milestone Jul 16, 2023
@oddbookworm oddbookworm merged commit 70ff637 into main Jul 16, 2023
54 checks passed
@ankith26 ankith26 deleted the ankith26-new-typing branch July 18, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type hints Type hint checking related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinate and _CanBeRect type aliases too restrictive
3 participants