Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old Window cython sources #2294

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Remove the old Window cython sources #2294

merged 3 commits into from
Jul 12, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Jul 7, 2023

No description provided.

@yunline yunline requested a review from a team as a code owner July 7, 2023 08:11
@Starbuck5 Starbuck5 added _sdl2 pygame._sdl2 Code quality/robustness Code quality and resilience to changes labels Jul 8, 2023
@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jul 8, 2023
@yunline @ankith26
Update buildconfig/stubs/pygame/_sdl2/window.pyi
05fbf8e 
Co-authored-by: Ankith <46915066+ankith26@users.noreply.github.com>
ankith26
ankith26 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with Window and _sdl2 but approving this nonetheless, thanks!

@Starbuck5 Starbuck5 merged commit 0cac7c2 into pygame-community:main Jul 12, 2023
29 checks passed
@yunline yunline deleted the remove-cython-window branch July 19, 2023 08:21
@yunline yunline mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2 window
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yunline @Starbuck5 @ankith26