Corrected get_pref_path() documentation #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path generated by get_pref_path should have included the "prg" parameter. (In the example, this has the value of "My Company")
ankith26
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Hi, thanks for making the PR.
The docs here was originally copied from the SDL docs for the underlying function (which also has this issue). I tested this on linux, and even on linux the orgname is taken into account as expected.
Co-authored-by: Ankith <46915066+ankith26@users.noreply.github.com>
ankith26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path generated by get_pref_path for MacOS should have included an extra folder using the "org" parameter. (In the example, this has the value of "My Company"). I tested this call on my Mac, and the generated path includes the value of "org" as an additional folder.