Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue moving away from format masks again #2328

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Continue moving away from format masks again #2328

merged 1 commit into from
Jul 22, 2023

Conversation

Starbuck5
Copy link
Member

Since SDL3 is all about pixelformat instead.

Continuing from #2123

@Starbuck5 Starbuck5 added the Code quality/robustness Code quality and resilience to changes label Jul 19, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner July 19, 2023 05:58
@Starbuck5
Continue moving away from format masks again
85161b5 
Since SDL3 is all about pixelformat instead.
ankith26
ankith26 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also like how these changes help in making the code simpler. Thanks! 🎈

zoldalma999
zoldalma999 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@zoldalma999 zoldalma999 merged commit 1ec2bbe into pygame-community:main Jul 22, 2023
29 checks passed
@zoldalma999 zoldalma999 modified the milestones: 2.4.0, 2.3.1 Jul 22, 2023
@Starbuck5 Starbuck5 added the sdl3 label Sep 8, 2023
@Starbuck5 Starbuck5 deleted the surface-format-masks3 branch September 8, 2023 04:26
@Starbuck5 Starbuck5 mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldalma999 zoldalma999 zoldalma999 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes sdl3
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Starbuck5 @zoldalma999 @ankith26