Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in video.c #2343

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix warnings in video.c #2343

merged 1 commit into from
Jul 27, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Jul 25, 2023

E}{BC)QLM}1 %(I7OSWOP

@yunline yunline added Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2 video pygame.video labels Jul 25, 2023
@yunline yunline requested a review from a team as a code owner July 25, 2023 00:45
oddbookworm
oddbookworm approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if casting 255.0 to float is necessary, but LGTM!

Edit: I am once again a dummy

ankith26
ankith26 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It looks mostly harmless and also fixes warnings 🍰

@ankith26 ankith26 added this to the 2.3.1 milestone Jul 27, 2023
@ankith26 ankith26 merged commit ecdf468 into pygame-community:main Jul 27, 2023
31 checks passed
@yunline yunline deleted the fix-cython-warning branch July 27, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2 video pygame.video
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yunline @ankith26 @oddbookworm