Add Named Colors to docs for pygame.draw and pygame.Surface #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated draw and surface pages to reference strings (named colors) as being accepted.
Starbuck5
reviewed
Jul 26, 2023
Starbuck5
reviewed
Jul 26, 2023
ankith26
reviewed
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the docs to reflect the changes suggested in #2273 which asked for the pygame.draw and pygame.Surface pages to more clearly articulate that strings for named colors can be used.
PLEASE NOTE - I'm not experienced with color palettes but I updated
set_paletteandset_palette_atin line with the rest as I could see in the code that they should also accept a ColorValue. Happy to amend as necessary if I've misunderstood.