Rename PyClockObject to pgClockObject, remove rendered field, small cleanups #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldalma999
force-pushed
the
clock-remove-rendered
branch
from
c9a1150
to
f0f061f
Compare
zoldalma999
changed the title
ankith26
reviewed
Jul 26, 2023
zoldalma999
force-pushed
the
clock-remove-rendered
branch
from
82ff81d
to
325a578
Compare
ankith26
added
Code quality/robustness
Starbuck5
reviewed
Jul 27, 2023
Starbuck5
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I could tell, nothing uses the rendered field, so no reason to keep it around
EDIT: I found the commit that added it. It had no use for it back then either. And there was no use added as far as I could tell.
Also changed the name from
PyClockObjecttopgClockObjectto be more consistent with all the other struct's names.Removed the
PyClockObject *_clock = (PyClockObject *)self;lines by makingselfs be already clock objects and casting the functions in the methods table