Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to Window.size and Window.position C code #2367

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Minor improvements to Window.size and Window.position C code #2367

merged 1 commit into from
Aug 1, 2023

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Jul 31, 2023

No description provided.

@Matiiss Matiiss added Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2 labels Jul 31, 2023
@Matiiss Matiiss requested a review from a team as a code owner July 31, 2023 22:02
yunline
yunline approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankith26
ankith26 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR ⭐

@ankith26 ankith26 merged commit 15700e9 into pygame-community:main Aug 1, 2023
32 checks passed
@ankith26 ankith26 added this to the 2.4.0 milestone Aug 1, 2023
@Matiiss Matiiss deleted the matiiss-improve-window-size-position-properties branch August 1, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunline yunline yunline approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes _sdl2 pygame._sdl2
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Matiiss @yunline @ankith26