Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mixer.Channel.id getter #2369

Merged
merged 6 commits into from
Aug 19, 2023
Merged

Conversation

oddbookworm
Copy link
Member

No description provided.

@oddbookworm oddbookworm requested a review from a team as a code owner August 1, 2023 04:00
@yunline yunline added New API This pull request may need extra debate as it adds a new class or function to pygame mixer pygame.mixer labels Aug 1, 2023
@Starbuck5
Copy link
Member

Starbuck5 commented Aug 2, 2023

@oddbookworm circleci is failing for you but it's passing on main. After scratching my head for a second on this, I believe it's because it's pulling the circleci config from YOUR (outdated) main branch, rather than the PR branch or pygame-ce's main branch.

@ankith26 tagging for visibility. I haven't thought about mitigation yet, but presumably we'd want circleci to use the config of the PR branches themselves, is there a way to have that?

@oddbookworm
Copy link
Member Author

Alright, I pulled in the most recent merges to both my own main and the PR branch

docs/reST/ref/mixer.rst Outdated Show resolved Hide resolved
@ankith26
Copy link
Member

ankith26 commented Aug 4, 2023

I haven't thought about mitigation yet, but presumably we'd want circleci to use the config of the PR branches themselves, is there a way to have that?

Yes I'd like that too, but unfortunately there's nothing much we can do about it AFAIK.

@MyreMylar MyreMylar added this to the 2.4.0 milestone Aug 14, 2023
docs/reST/ref/mixer.rst Outdated Show resolved Hide resolved
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

It's not earth shattering as users could already keep track of their own channel IDs mapping to channels if they wanted, but might make it slightly easier to find out/debug which channel a sound is playing on with a simple number.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is new API, how about considering making this a read-only property instead? Fewer characters to type and also pythonic

@oddbookworm
Copy link
Member Author

Since this is new API, how about considering making this a read-only property instead? Fewer characters to type and also pythonic

I'll push a commit soon for this

@oddbookworm
Copy link
Member Author

force push to fix a half-complete commit

@ankith26 ankith26 changed the title added mixer.Channel.get_id Add a mixer.Channel.id getter Aug 15, 2023
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 馃憤

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@ankith26 ankith26 merged commit b331282 into pygame-community:main Aug 19, 2023
32 checks passed
@oddbookworm oddbookworm deleted the channel_id branch December 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mixer pygame.mixer New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants