-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window grab API rework #2379
Window grab API rework #2379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works on my machine, I can grab the mouse and the keyboard shortcuts with the Window class all day long 👍 🎉
I added a couple of small documentation suggestion fixes along with this review. Feel free to fix them yourself or whoever ends up 2nd review and merging this can do so.
Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Used your test app (and modified it to make sure mouse grabbing works), and it did what it should. I also tested passing in grab_keyboard as an argument, that works too.
Fix problems caused by #2379
grab
->grab_mouse
grab_keyboard
mouse_grabbed
keyboard_grabbed
We already have
grab_mouse/keyboard
, why addmouse/keyboard_grabbed
?These attribute are for different uses.
grab_mouse
means whether the window will try to grab the mouse.mouse_grabbed
means whether the mouse is grabbed by this window.See docs for details.
TestCode