Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not skipping a mixer test that previously was failing often #2384

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Not skipping a mixer test that previously was failing often #2384

merged 1 commit into from
Aug 14, 2023

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Aug 5, 2023

Fixes #601 (hopefully)

@Matiiss Matiiss requested a review from a team as a code owner August 5, 2023 18:52
@yunline yunline added tests tests (module) mixer pygame.mixer labels Aug 7, 2023
ankith26
ankith26 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the issue is completely gone, but I'm inclined to merge this in and see how things go

MyreMylar
MyreMylar approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the issue is completely gone, but I'm inclined to merge this in and see how things go

Agreed.

@MyreMylar MyreMylar added this to the 2.3.2 milestone Aug 14, 2023
@MyreMylar MyreMylar merged commit ab7b953 into pygame-community:main Aug 14, 2023
31 checks passed
ankith26 pushed a commit that referenced this pull request Sep 2, 2023
@MyreMylar @ankith26
Merge pull request #2384 from Matiiss/matiiss-rerun-601
4e50c2a 
Not skipping a mixer test that previously was failing often
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
mixer pygame.mixer tests tests (module)
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

SDL2: Fix test_sound_args. Flaky MixerModuleTest. (892)
4 participants
@Matiiss @MyreMylar @ankith26 @yunline