Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubs for Color.__getitem__ #2391

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

ddorn
Copy link
Contributor

@ddorn ddorn commented Aug 10, 2023

A simple 5 characters change, as __getitem__ with a slice returns a tuple of variable length, not length one.

@ddorn ddorn requested a review from a team as a code owner August 10, 2023 11:00
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@ankith26 ankith26 added this to the 2.3.2 milestone Aug 10, 2023
@yunline yunline added type hints Type hint checking related tasks color pygame.color labels Aug 11, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit f021a15 into pygame-community:main Aug 14, 2023
30 checks passed
ankith26 pushed a commit that referenced this pull request Sep 2, 2023
Fix stubs for Color.__getitem__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color pygame.color type hints Type hint checking related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants