Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing out of range sequence lengths to colorspace setters #2392

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Deprecate passing out of range sequence lengths to colorspace setters #2392

merged 2 commits into from
Aug 19, 2023

Conversation

ankith26
Copy link
Member

First step for #2386

@ankith26 ankith26 requested a review from a team as a code owner August 10, 2023 18:21
@ankith26 ankith26 force-pushed the ankith26-colorspace-fix branch 2 times, most recently from 9e960b8 to 58a2f07 Compare August 10, 2023 18:28
@ankith26 ankith26 added this to the 2.3.2 milestone Aug 10, 2023
@ankith26 ankith26 changed the title Deprecate passing out of range range colorspace Deprecate passing out of range sequence lengths to colorspace setters Aug 10, 2023
MyreMylar
MyreMylar approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I'm hoping nobody ever sees these deprecation warnings anyway for undocumented 'functionality'.

dr0id
dr0id approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankith26 ankith26 merged commit b8ef17f into main Aug 19, 2023
32 checks passed
@ankith26 ankith26 deleted the ankith26-colorspace-fix branch August 19, 2023 16:13
ankith26 added a commit that referenced this pull request Sep 2, 2023
@ankith26
Merge pull request #2392 from pygame-community/ankith26-colorspace-fix
c4638ac 
Deprecate passing out of range sequence lengths to colorspace setters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
color pygame.color Deprecation Warning
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ankith26 @dr0id @MyreMylar