Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore lint warning in locals.py (to make the linter pass) #2393

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented Aug 11, 2023

this is needed to avoid a non 0 return value of python -m setup lint, at least on window using
py 3.10
black 23.7.0
clang 16.0.1.1
clang-format 16.0.4
pylint 2.17.5

@dr0id dr0id requested a review from a team as a code owner August 11, 2023 13:57
@dr0id dr0id self-assigned this Aug 12, 2023
@yunline yunline added the Code quality/robustness Code quality and resilience to changes label Aug 12, 2023
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar added this to the 2.3.2 milestone Aug 14, 2023
@MyreMylar MyreMylar merged commit 9bd4218 into pygame-community:main Aug 14, 2023
31 checks passed
ankith26 pushed a commit that referenced this pull request Sep 2, 2023
ignore lint warning in locals.py (to make the linter pass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants