Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deepcopy capability to Surface #2394

Merged
merged 4 commits into from
Aug 14, 2023
Merged

add deepcopy capability to Surface #2394

merged 4 commits into from
Aug 14, 2023

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented Aug 11, 2023

No description provided.

@dr0id dr0id requested a review from a team as a code owner August 11, 2023 14:24
ankith26
ankith26 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 馃帀

I'm thinking, should this be documented? Nothing too much, just a one line entry?

@dr0id
Copy link
Contributor Author

dr0id commented Aug 11, 2023

I'm thinking, should this be documented? Nothing too much, just a one line entry?

Well, copy isn't documented either. Not sure where it should be mentioned. Should some sentence be added to the documentation of copy()? Or as with the mask at class level?

@dr0id
Copy link
Contributor Author

dr0id commented Aug 11, 2023

I'm thinking, should this be documented? Nothing too much, just a one line entry?

Just added some line in the documentation.

@dr0id dr0id requested a review from ankith26 August 11, 2023 19:39
@dr0id dr0id self-assigned this Aug 12, 2023
@yunline yunline added enhancement Surface pygame.Surface labels Aug 12, 2023
@MyreMylar MyreMylar added this to the 2.3.2 milestone Aug 14, 2023
MyreMylar
MyreMylar approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Seems like a minor enough change to sneak into 2.3.2.

@MyreMylar MyreMylar merged commit c3d0c73 into pygame-community:main Aug 14, 2023
32 checks passed
ankith26 pushed a commit that referenced this pull request Sep 2, 2023
@MyreMylar @ankith26
Merge pull request #2394 from dr0id/bugfix/surface/deepcopy
fe4142b 
add deepcopy capability to Surface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 Awaiting requested review from ankith26

Assignees

@dr0id dr0id

Labels
enhancement Surface pygame.Surface
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dr0id @MyreMylar @Starbuck5 @ankith26 @yunline