Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: in 32bits mode (mvp) lseek64 is not present #2410

Merged
merged 2 commits into from
Aug 21, 2023
Merged

wasm: in 32bits mode (mvp) lseek64 is not present #2410

merged 2 commits into from
Aug 21, 2023

Conversation

pmp-p
Copy link
Member

@pmp-p pmp-p commented Aug 20, 2023

fix compilation on recent emsdk 3.1.45

@pmp-p pmp-p requested a review from a team as a code owner August 20, 2023 10:56
@yunline yunline added bugfix PR that fixes bug WebAssembly labels Aug 21, 2023
ankith26
ankith26 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🤩

@ankith26 ankith26 added this to the 2.3.2 milestone Aug 21, 2023
dr0id
dr0id approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmp-p pmp-p merged commit 91dc448 into pygame-community:main Aug 21, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug WebAssembly
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmp-p @dr0id @ankith26 @yunline