Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BUILD_STATIC instead of PYGAMEAPI_DISPLAY_INTERNAL in window.c #2412

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Use BUILD_STATIC instead of PYGAMEAPI_DISPLAY_INTERNAL in window.c #2412

merged 2 commits into from
Aug 21, 2023

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Aug 21, 2023

Fixes this.

if you need to protect a block from being statically linked a second time, just enclose it with #ifndef BUILD_STATIC

i fear PYGAMEAPI_DISPLAY_INTERNAL is unrelated to static build

Thank you for your suggestion @pmp-p.

@yunline
Update window.c
0ecdb32 
use BUILD_STATIC instead of PYGAMEAPI_DISPLAY_INTERNAL
@yunline yunline added the Code quality/robustness Code quality and resilience to changes label Aug 21, 2023
@yunline yunline requested a review from a team as a code owner August 21, 2023 12:42
pmp-p
pmp-p approved these changes Aug 21, 2023
View reviewed changes
src_c/window.c Outdated Show resolved Hide resolved
ankith26
ankith26 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

@ankith26 ankith26 merged commit d64a610 into pygame-community:main Aug 21, 2023
32 checks passed
@ankith26 ankith26 added this to the 2.3.2 milestone Aug 21, 2023
@yunline yunline deleted the use-BUILD_STATIC branch August 21, 2023 14:20
ankith26 added a commit that referenced this pull request Sep 2, 2023
@ankith26
Merge pull request #2412 from yunline/use-BUILD_STATIC
cb34434 
Use `BUILD_STATIC` instead of `PYGAMEAPI_DISPLAY_INTERNAL` in window.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmp-p pmp-p pmp-p approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yunline @pmp-p @ankith26