Fix caution visual bug for dark theme #2418
Conversation
There was a problem hiding this comment.
Thanks for your fix.
However, there are 2 bugs mentioned in the issue, and you just fixed one of them.
The another one is in https://pyga.me/docs/tutorials/en/move-it.html
|
@yunline It's fine for this PR to only fix one of the problems, as long as the original issue doesn't get closed. |
|
Just wanted to point out that we already have a color we use for a warning in the _sdl2 docs, should we try to be consistent and use the same color? IMO the red background color used in this PR seems a little dark to me?
|
|
Which I guess does lead to the question, rather than just apply changes to the dark mode, could we apply the background color/text color universally like we have for the above warning in sdl2_video? |
|
I think it is fine for us to have different colours for Warning and Caution boxes. I applied the suggestions from the earlier comments so we can get this merged. Caution boxes in the dark theme now look like this:
|
Old:
New:
reported by @yunline