Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping mixer test because it randomly fails on Linux #2438

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Sep 7, 2023

This test, especially recently, tends to fail randomly on Linux, skipping it for now until a solution is found.
image

@Matiiss Matiiss requested a review from a team as a code owner September 7, 2023 17:43
@Starbuck5
Copy link
Member

I don't really like skipping tests... I just wish this would consistently fail so it's easy to track down.

@yunline yunline added tests tests (module) mixer pygame.mixer labels Sep 18, 2023
@MyreMylar
Copy link
Member

If it is never failing locally on linux - but it is failing on CI, and it is about the data from files loaded into memory - could it be something to do with multiple tests accessing the same file at the same time (as the CI appears to compile and run tests from multiple modules in parallel).

If so, one idea to try first might be making a second copy of house_lo.wav called house_lo_sound_args_test.wav and use that only in this test and see if it clears up occurrences of this error? Of course it would increase our file size slightly.

@ankith26
Copy link
Member

Another observation: it always seems to fail on 32-bit platforms. I think hunting for the root cause and fixing it wouldn't be worth the effort (we have very very few, or practically no real users on 32-bit linux)

I think the test skip can be added but conditional on the platform being 32 bit

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Sep 28, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, time will tell if it cracks this test fail.

@MyreMylar MyreMylar merged commit 644fc36 into pygame-community:main Sep 29, 2023
30 of 31 checks passed
@Matiiss Matiiss deleted the matiiss-skipif-linux branch September 29, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mixer pygame.mixer tests tests (module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants