-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipping mixer test because it randomly fails on Linux #2438
Conversation
I don't really like skipping tests... I just wish this would consistently fail so it's easy to track down. |
If it is never failing locally on linux - but it is failing on CI, and it is about the data from files loaded into memory - could it be something to do with multiple tests accessing the same file at the same time (as the CI appears to compile and run tests from multiple modules in parallel). If so, one idea to try first might be making a second copy of |
Another observation: it always seems to fail on 32-bit platforms. I think hunting for the root cause and fixing it wouldn't be worth the effort (we have very very few, or practically no real users on 32-bit linux) I think the test skip can be added but conditional on the platform being 32 bit |
6b51080
to
94dfd62
Compare
f871dda
to
6dfd6aa
Compare
6dfd6aa
to
55f02b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, time will tell if it cracks this test fail.
This test, especially recently, tends to fail randomly on Linux, skipping it for now until a solution is found.