Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RAISE when appropriate #2444

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Use RAISE when appropriate #2444

merged 1 commit into from
Sep 10, 2023

Conversation

Starbuck5
Copy link
Member

Just a single pass, there are definitely other instances as well. These are just the easy ones.

@Starbuck5
Use RAISE when appropriate
539eddc 
Just a single pass, there are definitely other instances as well. These are just the easy ones.
@Starbuck5 Starbuck5 added the Code quality/robustness Code quality and resilience to changes label Sep 10, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner September 10, 2023 03:48
dr0id
dr0id approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankith26
ankith26 approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🍰

@ankith26 ankith26 merged commit 70796e7 into pygame-community:main Sep 10, 2023
32 checks passed
@ankith26 ankith26 added this to the 2.4.0 milestone Sep 10, 2023
@Starbuck5 Starbuck5 deleted the use-raise branch September 10, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Starbuck5 @dr0id @ankith26