Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental notice on system module #2459

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

Starbuck5
Copy link
Member

We're going to treat this module with as much back-compat effort as anything else right now, so this notice is moot.

@Starbuck5 Starbuck5 added docs system pygame.system labels Sep 20, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner September 20, 2023 08:13
We're going to treat this module with as much back-compat effort as anything else right now, so this notice is moot.
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like get_power_state to be in experimental state just in case something comes up (it hasn't seen a release yet)

I agree the rest should be leaving experimental status

@Starbuck5
Copy link
Member Author

As requested, I added a more specific experimental notice there.

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyreMylar MyreMylar added this to the 2.4.0 milestone Sep 24, 2023
@MyreMylar MyreMylar merged commit ac96f2b into pygame-community:main Sep 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs system pygame.system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants