-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uint64 underflow in tick_busy_loop
#2466
Fix uint64 underflow in tick_busy_loop
#2466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the window doesn't hang anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🎉
It was reported on discord that using
tick_busy_loop
could cause a crash in a specific scenario.Reproducer
It's an odd one though, I didn't see it on my own machine. After some troubleshooting with @Matiiss and the reporter, I believe it is due to an int underflow when there is a lag spike in cpu processing, causing
delay
to become insanely large (thus blocking thewhile
loop from ever finishing).I don't think a regression test is possible with our current framework